Skip to content

Commit

Permalink
src: fix unused private field warning
Browse files Browse the repository at this point in the history
PR-URL: #28036
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
cjihrig authored and danbev committed Jun 5, 2019
1 parent cb68c04 commit 2c76874
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/inspector/runtime_agent.cc
Expand Up @@ -7,8 +7,8 @@ namespace node {
namespace inspector {
namespace protocol {

RuntimeAgent::RuntimeAgent(Environment* env)
: notify_when_waiting_for_disconnect_(false), env_(env) {}
RuntimeAgent::RuntimeAgent()
: notify_when_waiting_for_disconnect_(false) {}

void RuntimeAgent::Wire(UberDispatcher* dispatcher) {
frontend_ = std::make_unique<NodeRuntime::Frontend>(dispatcher->channel());
Expand Down
3 changes: 1 addition & 2 deletions src/inspector/runtime_agent.h
Expand Up @@ -12,7 +12,7 @@ namespace protocol {

class RuntimeAgent : public NodeRuntime::Backend {
public:
explicit RuntimeAgent(Environment* env);
RuntimeAgent();

void Wire(UberDispatcher* dispatcher);

Expand All @@ -23,7 +23,6 @@ class RuntimeAgent : public NodeRuntime::Backend {
private:
std::shared_ptr<NodeRuntime::Frontend> frontend_;
bool notify_when_waiting_for_disconnect_;
Environment* env_;
};
} // namespace protocol
} // namespace inspector
Expand Down
2 changes: 1 addition & 1 deletion src/inspector_agent.cc
Expand Up @@ -239,7 +239,7 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
tracing_agent_->Wire(node_dispatcher_.get());
worker_agent_ = std::make_unique<protocol::WorkerAgent>(worker_manager);
worker_agent_->Wire(node_dispatcher_.get());
runtime_agent_ = std::make_unique<protocol::RuntimeAgent>(env);
runtime_agent_ = std::make_unique<protocol::RuntimeAgent>();
runtime_agent_->Wire(node_dispatcher_.get());
}

Expand Down

0 comments on commit 2c76874

Please sign in to comment.