Skip to content

Commit

Permalink
tools: fix redundant-move warning in inspector
Browse files Browse the repository at this point in the history
Currently, the following warning is generated from the inspector
protocol:
/out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:
In member function
‘virtual std::unique_ptr<node::inspector::protocol::Value>
    node::inspector::protocol::ListValue::clone() const’:
/out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:739:21:
error: redundant move in return statement [-Werror=redundant-move]
  739 |     return std::move(result);
      |            ~~~~~~~~~^~~~~~~~

This commit removes the move for DictionaryValue and ListValue.

PR-URL: #32685
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
  • Loading branch information
danbev committed Apr 30, 2020
1 parent a7ae7aa commit 2e441e1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/inspector_protocol/lib/Values_cpp.template
Expand Up @@ -606,7 +606,7 @@ std::unique_ptr<Value> DictionaryValue::clone() const
DCHECK(value != m_data.cend() && value->second);
result->setValue(key, value->second->clone());
}
return std::move(result);
return result;
}

DictionaryValue::DictionaryValue()
Expand Down Expand Up @@ -647,7 +647,7 @@ std::unique_ptr<Value> ListValue::clone() const
std::unique_ptr<ListValue> result = ListValue::create();
for (const std::unique_ptr<protocol::Value>& value : m_data)
result->pushValue(value->clone());
return std::move(result);
return result;
}

ListValue::ListValue()
Expand Down

0 comments on commit 2e441e1

Please sign in to comment.