Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: Mestery <mestery@pm.me>
  • Loading branch information
4 people committed Aug 18, 2021
1 parent 923a169 commit 2e552d5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions Makefile
Expand Up @@ -1060,6 +1060,7 @@ corepack-update:
cd /tmp/node-corepack-clone && yarn pack
rm -rf deps/corepack && mkdir -p deps/corepack
cd deps/corepack && tar xf /tmp/node-corepack-clone/package.tgz --strip-components=1
chmod +x deps/corepack/shims/*

# Note: this is strictly for release builds on release machines only.
pkg-upload: pkg
Expand Down
8 changes: 4 additions & 4 deletions doc/api/corepack.md
Expand Up @@ -5,7 +5,7 @@

> Stability: 1 - Experimental
_[Corepack][]_ is an experimental tool shipped with Node.js to help with
_[Corepack][]_ is an experimental tool to help with
managing versions of your package managers. It exposes binary proxies for
each [supported package manager][] that, when called, will identify whatever
package manager is configured for the current project, transparently install
Expand All @@ -25,7 +25,7 @@ This feature simplifies two core workflows:

### Enabling the feature

Due to its experimental status Corepack currently needs to be explicitly
Due to its experimental status, Corepack currently needs to be explicitly
enabled to have any effect. To do that simply run [`corepack enable`][], which
will set up the symlinks in your environment, next to the `node` binary
(and overwrite the existing symlinks if necessary).
Expand Down Expand Up @@ -59,7 +59,7 @@ corepack prepare yarn@x.y.z --activate

### Offline workflow

Many production environments don't have network accesses. Since Corepack
Many production environments don't have network access. Since Corepack
usually downloads the package manager releases straight from their registries,
it can conflict with such environments. To avoid that happening, call the
[`corepack prepare`][] command while you still have network access (typically at
Expand All @@ -75,7 +75,7 @@ The following binaries are provided through Corepack:

| Package manager | Binary names |
| --------------- | -------------- |
| [Yarn][] | `yarn` |
| [Yarn][] | `yarn`, `yarnpkg` |
| [pnpm][] | `pnpm`, `pnpx` |

## Troubleshooting
Expand Down
2 changes: 1 addition & 1 deletion tools/msvs/msi/i18n/it-it.wxl
Expand Up @@ -19,7 +19,7 @@
<String Id="npm_Description">Installa npm, il package manager raccomandato per [ProductName].</String>

<String Id="corepack_Title">corepack manager</String>
<String Id="corepack_Description">Install corepack, the universal package manager for [ProductName].</String>
<String Id="corepack_Description">Installa corepack, il package manager universale per [ProductName].</String>

<String Id="DocumentationShortcuts_Title">Collegamenti alla documentazione online</String>
<String Id="DocumentationShortcuts_Description">Aggiunge i collegamenti al menu start alla documentazione online per [ProductName] [FullVersion] e per il sito web di [ProductName].</String>
Expand Down

0 comments on commit 2e552d5

Please sign in to comment.