module: fix Windows folder exports deprecation warning

PR-URL: #36859 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
nodejs · Jan 12, 2021 · 2e909c4 · 2e909c4
1 parent ec794f9
commit 2e909c4
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 5 deletions.
diff --git a/lib/internal/modules/esm/resolve.js b/lib/internal/modules/esm/resolve.js
@@ -65,12 +65,11 @@ const emittedPackageWarnings = new SafeSet();
 function emitFolderMapDeprecation(match, pjsonUrl, isExports, base) {
   const pjsonPath = fileURLToPath(pjsonUrl);
   if (!pendingDeprecation) {
-    const nodeModulesIndex = StringPrototypeLastIndexOf(pjsonPath,
-                                                        '/node_modules/');
+    const nodeModulesIndex =
+        StringPrototypeLastIndexOf(pjsonPath, sep + 'node_modules' + sep);
     if (nodeModulesIndex !== -1) {
-      const afterNodeModulesPath = StringPrototypeSlice(pjsonPath,
-                                                        nodeModulesIndex + 14,
-                                                        -13);
+      const afterNodeModulesPath =
+          StringPrototypeSlice(pjsonPath, nodeModulesIndex + 14, -13);
       try {
         const { packageSubpath } = parsePackageName(afterNodeModulesPath);
         if (packageSubpath === '.')

diff --git a/test/es-module/test-esm-local-deprecations.mjs b/test/es-module/test-esm-local-deprecations.mjs
@@ -6,6 +6,9 @@ import { pathToFileURL } from 'url';
 const selfDeprecatedFolders =
     fixtures.path('/es-modules/self-deprecated-folders/main.js');
 
+const deprecatedFoldersIgnore =
+    fixtures.path('/es-modules/deprecated-folders-ignore/main.js');
+
 let curWarning = 0;
 const expectedWarnings = [
   '"./" in the "exports" field',
@@ -18,5 +21,6 @@ process.addListener('warning', mustCall((warning) => {
 
 (async () => {
   await import(pathToFileURL(selfDeprecatedFolders));
+  await import(pathToFileURL(deprecatedFoldersIgnore));
 })()
 .catch((err) => console.error(err));
diff --git a/test/fixtures/es-modules/deprecated-folders-ignore/main.js b/test/fixtures/es-modules/deprecated-folders-ignore/main.js
@@ -0,0 +1 @@
+import 'pkg/folder/m.js';
diff --git a/test/fixtures/es-modules/deprecated-folders-ignore/node_modules/pkg/m.js b/test/fixtures/es-modules/deprecated-folders-ignore/node_modules/pkg/m.js
diff --git a/test/fixtures/es-modules/deprecated-folders-ignore/node_modules/pkg/package.json b/test/fixtures/es-modules/deprecated-folders-ignore/node_modules/pkg/package.json
diff --git a/test/fixtures/es-modules/deprecated-folders-ignore/package.json b/test/fixtures/es-modules/deprecated-folders-ignore/package.json
@@ -0,0 +1,4 @@
+{
+  "type": "module"
+}
+