fixup! lib: expose primordials object

nodejs · Jan 17, 2021 · 2f67dae · 2f67dae
1 parent b74793f
commit 2f67dae
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 15 deletions.
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
@@ -52,7 +52,6 @@ const {
   ObjectKeys,
   ObjectPrototypeHasOwnProperty,
   ReflectGet,
-  ReflectGetOwnPropertyDescriptor,
   SafeMap,
   SafeSet,
   String,
@@ -217,19 +216,12 @@ class NativeModule {
   }
 
   // Used by user-land module loaders to compile and load builtins.
-  compileForPublicLoader(isPreloading) {
+  compileForPublicLoader() {
     if (!this.canBeRequiredByUsers) {
       // No code because this is an assertion against bugs
       // eslint-disable-next-line no-restricted-syntax
       throw new Error(`Should not compile ${this.id} for public use`);
     }
-    if (isPreloading) {
-      ObjectDefineProperty(
-        this, 'isPreloading',
-        ReflectGetOwnPropertyDescriptor(
-          nativeModuleRequire('internal/modules/cjs/loader').Module.prototype,
-          'isPreloading'));
-    }
     this.compileForInternalLoader();
     if (!this.exportKeys) {
       // When using --expose-internals, we do not want to reflect the named

diff --git a/lib/internal/modules/cjs/helpers.js b/lib/internal/modules/cjs/helpers.js
@@ -32,11 +32,11 @@ let debug = require('internal/util/debuglog').debuglog('module', (fn) => {
 // TODO: Use this set when resolving pkg#exports conditions in loader.js.
 const cjsConditions = new SafeSet(['require', 'node', ...userConditions]);
 
-function loadNativeModule(filename, request, isPreloading) {
+function loadNativeModule(filename, request) {
   const mod = NativeModule.map.get(filename);
   if (mod) {
     debug('load native module %s', request);
-    mod.compileForPublicLoader(isPreloading);
+    mod.compileForPublicLoader();
     return mod;
   }
 }

diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -233,9 +233,9 @@ ObjectDefineProperty(Module, 'wrapper', {
   }
 });
 
-ObjectDefineProperty(Module.prototype, 'isPreloading', {
-  get() { return isPreloading; }
-});
+const isPreloadingDesc = { get() { return isPreloading; } };
+ObjectDefineProperty(Module.prototype, 'isPreloading', isPreloadingDesc);
+ObjectDefineProperty(NativeModule.prototype, 'isPreloading', isPreloadingDesc);
 
 function getModuleParent() {
   return moduleParentCache.get(this);
@@ -781,7 +781,7 @@ Module._load = function(request, parent, isMain) {
     }
   }
 
-  const mod = loadNativeModule(filename, request, isPreloading);
+  const mod = loadNativeModule(filename, request);
   if (mod && mod.canBeRequiredByUsers) return mod.exports;
 
   // Don't call updateChildren(), Module constructor already does.