test,doc: enable running embedtest for Windows

Makefile

@@ -1439,6 +1439,7 @@ FORMAT_CPP_FILES += $(LINT_CPP_FILES)
 # C source codes.
 FORMAT_CPP_FILES += $(wildcard \
 	benchmark/napi/*/*.c \
+	test/embedding/*.c \
 	test/js-native-api/*.h \
 	test/js-native-api/*/*.c \
 	test/js-native-api/*/*.h \

doc/api/embedding.md

@@ -90,7 +90,7 @@ to as `node::Environment`. Each `node::Environment` is associated with:
 * A number of `v8::Context`s, but exactly one main `v8::Context`.
 * One `node::IsolateData` instance that contains information that could be
   shared by multiple `node::Environment`s that use the same `v8::Isolate`.
-  Currently, no testing if performed for this scenario.
+  Currently, no testing is performed for this scenario.
 
 In order to set up a `v8::Isolate`, an `v8::ArrayBuffer::Allocator` needs
 to be provided. One possible choice is the default Node.js allocator, which

node.gyp

@@ -1163,6 +1163,7 @@
       'sources': [
         'src/node_snapshot_stub.cc',
         'test/embedding/embedtest.cc',
+        'test/embedding/utf8_args.c',
       ],
 
       'conditions': [

test/embedding/embedtest.cc

@@ -1,9 +1,10 @@
 #ifdef NDEBUG
 #undef NDEBUG
 #endif
+#include <assert.h>
 #include "node.h"
+#include "utf8_args.h"
 #include "uv.h"
-#include <assert.h>
 
 #include <algorithm>
 
@@ -28,6 +29,8 @@ static int RunNodeInstance(MultiIsolatePlatform* platform,
                            const std::vector<std::string>& exec_args);
 
 int main(int argc, char** argv) {
+  GetUtf8CommandLineArgs(&argc, &argv);
+
   argv = uv_setup_args(argc, argv);
   std::vector<std::string> args(argv, argv + argc);
   std::unique_ptr<node::InitializationResult> result =
@@ -54,6 +57,8 @@ int main(int argc, char** argv) {
   V8::DisposePlatform();
 
   node::TearDownOncePerProcess();
+
+  FreeUtf8CommandLineArgs(argc, argv);
   return ret;
 }
 
@@ -106,7 +111,7 @@ int RunNodeInstance(MultiIsolatePlatform* platform,
   }
 
   if (!snapshot_blob_path.empty() && !is_building_snapshot) {
-    FILE* fp = fopen(snapshot_blob_path.c_str(), "r");
+    FILE* fp = fopen(snapshot_blob_path.c_str(), "rb");
     assert(fp != nullptr);
     if (snapshot_as_file) {
       snapshot = node::EmbedderSnapshotData::FromFile(fp);
@@ -204,7 +209,7 @@ int RunNodeInstance(MultiIsolatePlatform* platform,
     snapshot = setup->CreateSnapshot();
     assert(snapshot);
 
-    FILE* fp = fopen(snapshot_blob_path.c_str(), "w");
+    FILE* fp = fopen(snapshot_blob_path.c_str(), "wb");
     assert(fp != nullptr);
     if (snapshot_as_file) {
       snapshot->ToFile(fp);

test/embedding/utf8_args.c

@@ -0,0 +1,47 @@
+#include "utf8_args.h"
+
+#ifdef _WIN32
+
+#include <malloc.h>
+#include <shellapi.h>
+#include <windows.h>
+
+void GetUtf8CommandLineArgs(int* argc, char*** argv) {
+  int wargc;
+  wchar_t** wargv = CommandLineToArgvW(GetCommandLineW(), &wargc);
+  if (wargv == NULL) {
+    *argc = 0;
+    *argv = NULL;
+    return;
+  }
+
+  *argc = wargc;
+  *argv = (char**)malloc(wargc * sizeof(char*));
+  for (int i = 0; i < wargc; ++i) {
+    int len =
+        WideCharToMultiByte(CP_UTF8, 0, wargv[i], -1, NULL, 0, NULL, NULL);
+    (*argv)[i] = malloc(len);
+    WideCharToMultiByte(CP_UTF8, 0, wargv[i], -1, (*argv)[i], len, NULL, NULL);
+  }
+
+  LocalFree(wargv);
+}
+
+void FreeUtf8CommandLineArgs(int argc, char** argv) {
+  for (int i = 0; i < argc; ++i) {
+    free(argv[i]);
+  }
+  free(argv);
+}
+
+#else
+
+void GetUtf8CommandLineArgs(int* /*argc*/, char*** /*argv*/) {
+  // Do nothing on non-Windows platforms.
+}
+
+void FreeUtf8CommandLineArgs(int /*argc*/, char** /*argv*/) {
+  // Do nothing on non-Windows platforms.
+}
+
+#endif

test/embedding/utf8_args.h

@@ -0,0 +1,20 @@
+#ifndef TEST_EMBEDDING_UTF8_ARGS_H_
+#define TEST_EMBEDDING_UTF8_ARGS_H_
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+// Windows does not support UTF-8 command line arguments.
+// We must get them using an alternative way.
+// This function does nothing on non-Windows platforms.
+void GetUtf8CommandLineArgs(int* argc, char*** argv);
+
+// Free the memory allocated by GetUtf8CommandLineArgs.
+void FreeUtf8CommandLineArgs(int argc, char** argv);
+
+#ifdef __cplusplus
+}  // extern "C"
+#endif
+
+#endif  // TEST_EMBEDDING_UTF8_ARGS_H_

vcbuild.bat

@@ -324,6 +324,7 @@ if "%target%"=="Build" (
   if defined cctest set target="Build"
 )
 if "%target%"=="node" if exist "%config%\cctest.exe" del "%config%\cctest.exe"
+if "%target%"=="node" if exist "%config%\embedtest.exe" del "%config%\embedtest.exe"
 if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_args%"
 @rem Setup env variables to use multiprocessor build
 set UseMultiToolTask=True
@@ -633,6 +634,9 @@ if not exist "%config%\cctest.exe" echo cctest.exe not found. Run "vcbuild test"
 echo running 'cctest %cctest_args%'
 "%config%\cctest" %cctest_args%
 if %errorlevel% neq 0 set exit_code=%errorlevel%
+echo running '%node_exe% test\embedding\test-embedding.js'
+"%node_exe%" test\embedding\test-embedding.js
+if %errorlevel% neq 0 set exit_code=%errorlevel%
 :run-test-py
 echo running 'python tools\test.py %test_args%'
 python tools\test.py %test_args%