Skip to content

Commit 3c8daa3

Browse files
FlarnaMylesBorins
authored andcommittedMar 4, 2020
events: convert errorMonitor to a normal property
Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: #30932 (comment) PR-URL: #31848 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent be90817 commit 3c8daa3

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed
 

‎lib/events.js

+1-6
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,7 @@ ObjectDefineProperty(EventEmitter, 'captureRejections', {
9090
enumerable: true
9191
});
9292

93-
ObjectDefineProperty(EventEmitter, 'errorMonitor', {
94-
value: kErrorMonitor,
95-
writable: false,
96-
configurable: true,
97-
enumerable: true
98-
});
93+
EventEmitter.errorMonitor = kErrorMonitor;
9994

10095
// The default for captureRejections is false
10196
ObjectDefineProperty(EventEmitter.prototype, kCapture, {

0 commit comments

Comments
 (0)
Please sign in to comment.