v13.10.1 proposal #32099
Merged
v13.10.1 proposal #32099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: #31789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #31922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Separating this out from the QUIC PR to allow it to be separately reviewed. The QUIC implementation makes use of the hdr_histogram for dynamic performance monitoring. This introduces a BaseObject class that allows the internal histograms to be accessed on the JavaScript side and adds a generic Histogram class that will be used by both QUIC and perf_hooks (for the event loop delay monitoring). Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31988 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
OpenSSL s_server accepts port 0 as an indicator to use an open port provided by the operating system. Use that instead of common.PORT in the test. Remove 500ms delay added in 8e46167. Hopefully the race condition in OpenSSL s_server has been fixed and/or the change to port 0 means that the server is listening by the time the ACCEPT text is printed and the setTimeout() is no longer necessary. PR-URL: #32024 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: #30932 (comment) PR-URL: #31848 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #31995 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Two things in one on this commit:
(a) For the QUIC implementation, we need to separate out various bits
from node_crypto.cc to allow them to be reused. That's where this
commit starts.
(b) Quite a bit of the node_crypto.cc code was just messy in terms of
it's organization and lack of error handling and use of Local vs.
MaybeLocal. This cleans that up a bit and hopefully makes certain
parts a bit more manageable also.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #32016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
We create an object file in assembly which introduces the symbol `__node_text_start` into the .text section and place the resulting object file as the first file the linker encounters. We do this to ensure that we can recognize the boundaries of the .text section when attempting to establish the address range to map to large pages. Additionally, we rename the section containing the remapping code from `.lpstub` to `lpstub` so as to take advantage of the linker's feature whereby it inserts the symbol `__start_lpstub` when the section's name can be rendered as a valid C variable. We need this symbol in order to avoid self-mapping the remapping code to large pages, because doing so would cause the process to crash. PR-URL: #31981 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #31902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Allow using the handle more directly for I/O in other parts of the codebase. Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> ``` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31871 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
The ninja build places objects in a different directory. Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32071 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: #31741 PR-URL: #31792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: #32094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
nodejs-github-bot
added
lib / src
This comment has been minimized.
This comment has been minimized.
MylesBorins
force-pushed
the
v13.10.1-proposal
branch
from
c2807db
to
0a1c440
Compare
This comment has been minimized.
This comment has been minimized.
3 tasks
This comment has been minimized.
This comment has been minimized.
This was an oversight in 9fdb6e6. Fixing this is necessary to make `executionAsyncResource()` work as expected. Refs: #30959 Fixes: #32060 PR-URL: #32063 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
Mar 4, 2020
Notable changes: In Node.js 13.9.0 deps/zlib was switched to the chromium maintained implementation. This change had the unforseen consequence of breaking building from the tarballs we release as we were too aggressively removing `unneccessary files` from the `deps/zlib` folder. This release includes a patch that ensures that individuals will once again be able to build Node.js from source. PR-URL: #32099
MylesBorins
force-pushed
the
v13.10.1-proposal
branch
from
0a1c440
to
801b9a7
Compare
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29555/ Arm rebuilds:
edit :Keep getting connection resets on arm. Unsure if this is an infrastructure issue. Reran complete CI suite to see if maybe we'll have better luck |
BethGriggs
reviewed
Mar 4, 2020
BethGriggs
reviewed
Mar 4, 2020
Notable changes: In Node.js 13.9.0 deps/zlib was switched to the chromium maintained implementation. This change had the unforseen consequence of breaking building from the tarballs we release as we were too aggressively removing `unneccessary files` from the `deps/zlib` folder. This release includes a patch that ensures that individuals will once again be able to build Node.js from source. PR-URL: #32099
MylesBorins
force-pushed
the
v13.10.1-proposal
branch
from
69e0da6
to
59ab6bf
Compare
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29559/ edit from @MylesBorins: The only failure on this CI run was arm. After a handful of runs we were able to get a green run on both centos arm64 and ubuntu arm64, the two platforms regularly flaky while testing this release. I believe the issue we are running into is network related, but will make myself available for a quick follow up release if we actually broke anything. Also worth mentioning I was able to reproduce the failures on 13.10.0, so we can't be that much worse off pushing 13.10.1 than we are doing nothing 😅 |
|
https://nodejs.org/download/rc/v13.10.1-rc.0/ appears to be missing the source tarball. |
|
@richardlau it is still building 😅 |
BethGriggs
approved these changes
Mar 5, 2020
|
So... I've been banging my head against CI for a little bit and I am going to make the executive decision to move forward even though we are seeing odd issues with arm 💀 After doing all the digging I can do with the tools available to me I strongly believe the issue to be network based. Further we've managed to get a green run on each platform at least once. I've put a more in depth explanation above |
MylesBorins
added a commit
that referenced
this pull request
Mar 5, 2020
Notable changes: In Node.js 13.9.0 deps/zlib was switched to the chromium maintained implementation. This change had the unforseen consequence of breaking building from the tarballs we release as we were too aggressively removing `unneccessary files` from the `deps/zlib` folder. This release includes a patch that ensures that individuals will once again be able to build Node.js from source. PR-URL: #32099
MylesBorins
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Mar 5, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-03-04, Version 13.10.1 (Current), @MylesBorins
Notable Changes
In Node.js 13.9.0 deps/zlib was switched to the chromium maintained implementation. This change
had the unforseen consequence of breaking building from the tarballs we release as we were too
aggressively removing
unneccessary filesfrom thedeps/zlibfolder. This release includesa patch that ensures that individuals will once again be able to build Node.js from source.
Commits
723aa41d96] - build: fix zlib tarball generation (Shelley Vohr) #320949c1ac50fc5] - build: fix building with ninja (Richard Lau) #32071478450d6b3] - build: add asan check in Github action (gengjiawen) #319020fc45f80b5] - crypto: simplify exportKeyingMaterial (Tobias Nießen) #319224dc59b91a7] - dgram: make UDPWrap more reusable (Anna Henningsen) #318714ed720e940] - doc: visibility of Worker threads cli options (Harshitha KP) #313802518213a1b] - doc: improve doc/markdown file organization coherence (ConorDavenport) #31792ba3f7ff94d] - doc: update stream.pipeline() signature (vsemozhetbyt) #317893c8daa3aa0] - events: convert errorMonitor to a normal property (Gerhard Stoebich) #318486b44df2415] - perf,src: add HistogramBase and internal/histogram.js (James M Snell) #319886a9cea9ed2] - src: pass resource object along with InternalMakeCallback (Anna Henningsen) #3206370f046010c] - src: start the .text section with an asm symbol (Gabriel Schulhof) #31981755da035ce] - src: add node_crypto_common and refactor (James M Snell) #320164d5318c164] - src: improve handling of internal field counting (James M Snell) #319601539928ed9] - test: add GC test for disabled AsyncLocalStorage (Andrey Pechkurov) #31995be90817558] - test: remove common.port from test-tls-securepair-client (Rich Trott) #32024