Skip to content

Commit

Permalink
tools: fix type mismatch in test runner
Browse files Browse the repository at this point in the history
`output.diagnostic` is a list that is appended to on SmartOS when
retrying a test due to `ECONNREFUSED`. The test runner checks if
`output.diagnostic` is truthy and, if so, assigns its value to
`self.traceback`. However `self.traceback` is supposed to be a string,
and `_printDiagnostic()` in the `TapProgressIndicator` attempts to call
`splitlines()` on it, which fails if it is a list with:
AttributeError: 'list' object has no attribute 'splitlines'
  • Loading branch information
richardlau committed Apr 18, 2021
1 parent 767643f commit 3ee6a99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/test.py
Expand Up @@ -375,7 +375,7 @@ def HasRun(self, output):

if output.diagnostic:
self.severity = 'ok'
self.traceback = output.diagnostic
self.traceback = '\n'.join(output.diagnostic)


duration = output.test.duration
Expand Down

0 comments on commit 3ee6a99

Please sign in to comment.