Skip to content

Commit

Permalink
test: improve test-arm-math-illegal-instruction
Browse files Browse the repository at this point in the history
Instead of writing each Math function and keeping track, loop over Math
functions and test each one of them.

PR-URL: #37670
Reviewed-By: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
marsonya authored and targos committed May 1, 2021
1 parent 5c60087 commit 3f86dc1
Showing 1 changed file with 7 additions and 27 deletions.
34 changes: 7 additions & 27 deletions test/parallel/test-arm-math-illegal-instruction.js
Expand Up @@ -6,30 +6,10 @@ require('../common');
// See https://github.com/nodejs/node/issues/1376
// and https://code.google.com/p/v8/issues/detail?id=4019

Math.abs(-0.5);
Math.acos(-0.5);
Math.acosh(-0.5);
Math.asin(-0.5);
Math.asinh(-0.5);
Math.atan(-0.5);
Math.atanh(-0.5);
Math.cbrt(-0.5);
Math.ceil(-0.5);
Math.cos(-0.5);
Math.cosh(-0.5);
Math.exp(-0.5);
Math.expm1(-0.5);
Math.floor(-0.5);
Math.fround(-0.5);
Math.log(-0.5);
Math.log10(-0.5);
Math.log1p(-0.5);
Math.log2(-0.5);
Math.round(-0.5);
Math.sign(-0.5);
Math.sin(-0.5);
Math.sinh(-0.5);
Math.sqrt(-0.5);
Math.tan(-0.5);
Math.tanh(-0.5);
Math.trunc(-0.5);
// Iterate over all Math functions
Object.getOwnPropertyNames(Math).forEach((functionName) => {
if (!/[A-Z]/.test(functionName)) {
// The function names don't have capital letters.
Math[functionName](-0.5);
}
});

0 comments on commit 3f86dc1

Please sign in to comment.