src: remove v8abbr.h

The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed. Refs: #43652
nodejs · Aug 25, 2022 · 40bc0a2 · 40bc0a2
1 parent 15aa34b
commit 40bc0a2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 126 deletions.
diff --git a/.github/label-pr-config.yml b/.github/label-pr-config.yml
@@ -21,7 +21,7 @@ subSystemLabels:
   /^src\/tty_/: c++, tty
   /^src\/node_url/: c++, whatwg-url
   /^src\/node_util/: c++, util
-  /^src\/(?:node_v8|v8abbr)/: c++, v8 engine
+  /^src\/node_v8/: c++, v8 engine
   /^src\/node_contextify/: c++, vm
   /^src\/.*win32.*/: c++, windows
   /^src\/node_zlib/: c++, zlib

diff --git a/src/node_postmortem_metadata.cc b/src/node_postmortem_metadata.cc
@@ -3,9 +3,10 @@
 #include "handle_wrap.h"
 #include "util-inl.h"
 #include "req_wrap.h"
-#include "v8abbr.h"
 #include "node_context_data.h"
 
+#define NODE_OFF_EXTSTR_DATA sizeof(void*)
+
 #define NODEDBG_SYMBOL(Name)  nodedbg_ ## Name
 
 // nodedbg_offset_CLASS__MEMBER__TYPE: Describes the offset to a class member.

diff --git a/src/v8abbr.h b/src/v8abbr.h
diff --git a/test/cctest/test_node_postmortem_metadata.cc b/test/cctest/test_node_postmortem_metadata.cc
@@ -5,7 +5,8 @@
 #include "req_wrap-inl.h"
 #include "tracing/agent.h"
 #include "v8.h"
-#include "v8abbr.h"
+
+#define NODE_OFF_EXTSTR_DATA sizeof(void*)
 
 extern "C" {
 extern uintptr_t