fixup

nodejs · Aug 23, 2021 · 48eb663 · 48eb663
1 parent 1f4e70e
commit 48eb663
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 34 deletions.
diff --git a/lib/internal/streams/duplexify.js b/lib/internal/streams/duplexify.js
@@ -206,15 +206,17 @@ module.exports = function duplexify(body, name) {
 function fromAsyncGen(fn) {
   let { promise, resolve } = createDeferredPromise();
   const ac = new AbortController();
+  const signal = ac.signal;
   const value = fn(async function*() {
     while (true) {
       const { chunk, done, cb } = await promise;
       process.nextTick(cb);
       if (done) return;
+      if (signal.aborted) throw new AbortError();
       yield chunk;
       ({ promise, resolve } = createDeferredPromise());
     }
-  }(), { signal: ac.signal });
+  }(), { signal });
 
   return {
     value,

diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js
@@ -1390,39 +1390,6 @@ const tsp = require('timers/promises');
   }));
 }
 
-{
-  const writableLike = new Stream();
-  writableLike.writableNeedDrain = true;
-
-  pipeline(
-    async function *() {},
-    writableLike,
-    common.mustCall((err) => {
-      assert.strictEqual(err.code, 'ERR_STREAM_PREMATURE_CLOSE');
-    })
-  );
-
-  writableLike.emit('close');
-}
-
-{
-  const writableLike = new Stream();
-  writableLike.write = () => false;
-
-  pipeline(
-    async function *() {
-      yield null;
-      yield null;
-    },
-    writableLike,
-    common.mustCall((err) => {
-      assert.strictEqual(err.code, 'ERR_STREAM_PREMATURE_CLOSE');
-    })
-  );
-
-  writableLike.emit('close');
-}
-
 {
   const ac = new AbortController();
   const signal = ac.signal;