Skip to content

Commit

Permalink
doc: edit N-API introductory material in Collaborator Guide
Browse files Browse the repository at this point in the history
Use shorter, clearer sentences. Remove passive voice and personal
pronouns.

PR-URL: #26051
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and targos committed Feb 14, 2019
1 parent 44fc2f6 commit 4a254a6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,9 @@ For pull requests introducing new core modules:

### Additions to N-API

N-API provides an ABI stable API that we will have to support in future
versions without the usual option to modify or remove existing APIs on
SemVer boundaries. Therefore, additions need to be managed carefully.
N-API provides an ABI-stable API guaranteed for future Node.js versions.
Existing N-API APIs cannot change or disappear, even in semver-major releases.
Thus, N-API additions call for unusual care and scrutiny.

This
[guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md)
Expand Down

0 comments on commit 4a254a6

Please sign in to comment.