Skip to content

Commit

Permalink
test: skip stringbytes-external-exceed-max on AIX
Browse files Browse the repository at this point in the history
Add SKIP status for more tests in stringbytes-external-exceed-max that
are failing on AIX.
  • Loading branch information
sam-github committed Jul 4, 2019
1 parent 39a9358 commit 4c57272
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
12 changes: 12 additions & 0 deletions test/addons/addon.status
@@ -0,0 +1,12 @@
prefix addons

[true] # This section applies to all platforms

[$system==aix]
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
# https://github.com/nodejs/node/pull/28469
# https://github.com/nodejs/node/pull/28516
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js: SKIP

# https://github.com/nodejs/node/pull/28516
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: SKIP
Expand Up @@ -5,11 +5,6 @@ const skipMessage = 'intensive toString tests due to memory confinements';
if (!common.enoughTestMem)
common.skip(skipMessage);

// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
// See https://github.com/nodejs/node/pull/28469
if (process.platform === 'aix')
common.skip('flaky on AIX');

const binding = require(`./build/${common.buildType}/binding`);

// v8 fails silently if string length > v8::String::kMaxLength
Expand Down

0 comments on commit 4c57272

Please sign in to comment.