Skip to content

Commit

Permalink
http: runtime deprecate legacy HTTP parser
Browse files Browse the repository at this point in the history
The legacy HTTP parser, used by default in versions of Node.js prior to
12.0.0, is deprecated. The legacy HTTP parser cannot be guaranteed to be
supported after April 2021. This commit introduces a deprecation warning
for the legacy HTTP parser.
  • Loading branch information
BethGriggs committed Mar 5, 2021
1 parent 6cef0e3 commit 50b3ce8
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -2469,12 +2469,15 @@ Module.createRequireFromPath() is deprecated. Please use [`module.createRequire(
### DEP0131: Legacy HTTP parser
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/TBD
description: Runtime deprecation.
- version: v12.3.0
pr-url: https://github.com/nodejs/node/pull/27498
description: Documentation-only.
-->

Type: Documentation-only
Type: Runtime

The legacy HTTP parser, used by default in versions of Node.js prior to 12.0.0,
is deprecated. This deprecation applies to users of the
Expand Down
7 changes: 7 additions & 0 deletions src/node_http_parser_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@

#include "node.h"
#include "node_buffer.h"
#ifndef NODE_EXPERIMENTAL_HTTP
#include "node_process.h"
#endif /* NODE_EXPERIMENTAL_HTTP */
#include "util.h"

#include "async_wrap-inl.h"
Expand Down Expand Up @@ -1021,6 +1024,10 @@ void InitializeHttpParser(Local<Object> target,
#ifndef NODE_EXPERIMENTAL_HTTP
static uv_once_t init_once = UV_ONCE_INIT;
uv_once(&init_once, InitMaxHttpHeaderSizeOnce);
ProcessEmitDeprecationWarning(
env,
"The legacy HTTP parser is deprecated.",
"DEP0131").IsNothing();
#endif /* NODE_EXPERIMENTAL_HTTP */
}

Expand Down
11 changes: 11 additions & 0 deletions test/parallel/test-http-parser-legacy-deprecation.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'use strict';
const common = require('../common');

// Flags: --http-parser=legacy
require('http');

common.expectWarning({
DeprecationWarning:
['The legacy HTTP parser is deprecated.',
'DEP0131']
});

0 comments on commit 50b3ce8

Please sign in to comment.