Skip to content

Commit

Permalink
test: increase coverage for diagnostics_channel
Browse files Browse the repository at this point in the history
1. test subscribe with invalid args
https://coverage.nodejs.org/coverage-21f2e8859dfbf09f/lib/diagnostics_channel.js.html#L27

2. test create channel with invalid args
https://coverage.nodejs.org/coverage-21f2e8859dfbf09f/lib/diagnostics_channel.js.html#L98

PR-URL: #36602
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
  • Loading branch information
Lxxyx authored and jasnell committed Dec 31, 2020
1 parent b8c15c7 commit 51dfb86
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ channel.publish(input);
// Should not publish after subscriber is unsubscribed
channel.unsubscribe(subscriber);
assert.ok(!channel.hasSubscribers);

assert.throws(() => {
channel.subscribe(null);
}, { code: 'ERR_INVALID_ARG_TYPE' });
6 changes: 6 additions & 0 deletions test/parallel/test-diagnostics-channel-symbol-named.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@ channel.subscribe(common.mustCall((message, name) => {
}));

channel.publish(input);

{
assert.throws(() => {
dc.channel(null);
}, /ERR_INVALID_ARG_TYPE/);
}

0 comments on commit 51dfb86

Please sign in to comment.