events: add tests, better toString

PR-URL: #33622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · May 30, 2020 · 56e4460 · 56e4460
1 parent 697bcd9
commit 56e4460
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -282,6 +282,7 @@ class EventTarget {
 
     return `${name} ${inspect({}, opts)}`;
   }
+  get [Symbol.toStringTag]() { return 'EventTarget'; }
 }
 
 Object.defineProperties(EventTarget.prototype, {

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -75,7 +75,15 @@ ok(EventTarget);
   eventTarget.removeEventListener('foo', ev1);
   eventTarget.dispatchEvent(new Event('foo'));
 }
-
+{
+  // event subclassing
+  const SubEvent = class extends Event {};
+  const ev = new SubEvent('foo');
+  const eventTarget = new EventTarget();
+  const fn = common.mustCall((event) => strictEqual(event, ev));
+  eventTarget.addEventListener('foo', fn, { once: true });
+  eventTarget.dispatchEvent(ev);
+}
 {
   const eventTarget = new NodeEventTarget();
   strictEqual(eventTarget.listenerCount('foo'), 0);
@@ -384,3 +392,10 @@ ok(EventTarget);
   target.removeEventListener('foo', a, { capture: false });
   target.dispatchEvent(new Event('foo'));
 }
+
+{
+  const target = new EventTarget();
+  strictEqual(target.toString(), '[object EventTarget]');
+  const event = new Event();
+  strictEqual(event.toString(), '[object Event]');
+}