Skip to content

Commit

Permalink
test: do not run release-npm test without crypto
Browse files Browse the repository at this point in the history
npm requires crypto support and cannot be loaded without it.

PR-URL: #30265
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
targos committed Nov 14, 2019
1 parent b9fd18f commit 56e986a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/parallel/test-release-npm.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ const path = require('path');

const releaseReg = /^v\d+\.\d+\.\d+$/;

if (!releaseReg.test(process.version)) {
// Npm requires crypto support.
if (!releaseReg.test(process.version) || !common.hasCrypto) {
common.skip('This test is only for release builds');
}

{
// Verify that npm does not print out a warning when executed
// Verify that npm does not print out a warning when executed.

const npmCli = path.join(__dirname, '../../deps/npm/bin/npm-cli.js');
const npmExec = child_process.spawnSync(process.execPath, [npmCli]);
Expand Down

0 comments on commit 56e986a

Please sign in to comment.