Skip to content

Commit

Permalink
doc: add extra step for reporter pre-approval
Browse files Browse the repository at this point in the history
As discussed in the #security-triagge (OpenJS channel). To avoid insufficient CVE fixes across Security Release, might make sense to request a reporter pre-approval.
  • Loading branch information
RafaelGSS committed Sep 27, 2022
1 parent e0c5b44 commit 5860adc
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions doc/contributing/security-release-process.md
Expand Up @@ -66,6 +66,10 @@ The current security stewards are documented in the main Node.js
* [ ] Check that all vulnerabilities are ready for release integration:
* PRs against all affected release lines or cherry-pick clean
* Approved
* (optional) Approved by the reporter
* Build and send the binary to the reporter according to its architecture
and ask for a review. This step is important to avoid insufficient fixes
between Security Releases.
* Pass `make test`
* Have CVEs
* Make sure that dependent libraries have CVEs for their issues. We should
Expand Down

0 comments on commit 5860adc

Please sign in to comment.