fixup! fixup! src: make BuiltinLoader threadsafe and non-global

nodejs · Jan 10, 2023 · 591a4d1 · 591a4d1
1 parent a26322c
commit 591a4d1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -126,8 +126,6 @@
 
 namespace node {
 
-using builtins::BuiltinLoader;
-
 using v8::EscapableHandleScope;
 using v8::Isolate;
 using v8::Local;

diff --git a/src/node_realm.cc b/src/node_realm.cc
@@ -8,7 +8,6 @@
 
 namespace node {
 
-using builtins::BuiltinLoader;
 using v8::Context;
 using v8::EscapableHandleScope;
 using v8::Function;

diff --git a/src/node_threadsafe_cow.h b/src/node_threadsafe_cow.h
@@ -80,8 +80,8 @@ class ThreadsafeCopyOnWrite final {
 
  private:
   struct Impl {
-    Impl(const T& data) : data(data) {}
-    Impl(T&& data) : data(std::move(data)) {}
+    explicit Impl(const T& data) : data(data) {}
+    explicit Impl(T&& data) : data(std::move(data)) {}
 
     Impl(const Impl& other);
     Impl& operator=(const Impl& other) = delete;