Add readme

Co-authored-by: Rich Trott <rtrott@gmail.com>
nodejs · Oct 18, 2020 · 62c32dc · 62c32dc
1 parent d313252
commit 62c32dc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1295,7 +1295,7 @@ function urlToOptions(url) {
   return options;
 }
 
-const forwardSlashRegEx = /\//g;
+const forwardSlashesRegEx = /\/+/g;
 
 function getPathFromURLWin32(url) {
   const hostname = url.hostname;
@@ -1311,7 +1311,7 @@ function getPathFromURLWin32(url) {
       }
     }
   }
-  pathname = pathname.replace(forwardSlashRegEx, '\\');
+  pathname = pathname.replace(forwardSlashesRegEx, '\\');
   pathname = decodeURIComponent(pathname);
   if (hostname !== '') {
     // If hostname is set, then we have a UNC path
@@ -1336,7 +1336,7 @@ function getPathFromURLPosix(url) {
   if (url.hostname !== '') {
     throw new ERR_INVALID_FILE_URL_HOST(platform);
   }
-  const pathname = url.pathname;
+  let pathname = url.pathname;
   for (let n = 0; n < pathname.length; n++) {
     if (pathname[n] === '%') {
       const third = pathname.codePointAt(n + 2) | 0x20;
@@ -1347,6 +1347,7 @@ function getPathFromURLPosix(url) {
       }
     }
   }
+  pathname = pathname.replace(forwardSlashesRegEx, '/');
   return decodeURIComponent(pathname);
 }
 

diff --git a/test/common/README.md b/test/common/README.md
@@ -378,6 +378,11 @@ const { spawn } = require('child_process');
 spawn(...common.pwdCommand, { stdio: ['pipe'] });
 ```
 
+### `requireNoPackageJSONAbove()`
+
+Throws an `AssertionError` if a `package.json` file is in any ancestor
+directory. Such files may interfere with proper test functionality.
+
 ### `runWithInvalidFD(func)`
 
 * `func` [&lt;Function>][]