test: remove common.skipIfReportDisabled()

The report feature won't ever be disabled moving forward, so checking for its existence in the tests is no longer needed. PR-URL: #32242 Fixes: #26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs · Apr 28, 2020 · 6a0bc83 · 6a0bc83
1 parent 984ae30
commit 6a0bc83
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 15 deletions.
diff --git a/test/common/index.js b/test/common/index.js
@@ -566,12 +566,6 @@ function skipIfInspectorDisabled() {
   }
 }
 
-function skipIfReportDisabled() {
-  if (!process.config.variables.node_report) {
-    skip('Diagnostic reporting is disabled');
-  }
-}
-
 function skipIf32Bits() {
   if (bits < 64) {
     skip('The tested feature is not available in 32bit builds');
@@ -714,7 +708,6 @@ const common = {
   skipIf32Bits,
   skipIfEslintMissing,
   skipIfInspectorDisabled,
-  skipIfReportDisabled,
   skipIfWorker,
 
   get enoughTestCpu() {

diff --git a/test/report/test-report-config.js b/test/report/test-report-config.js
@@ -1,7 +1,6 @@
 // Flags: --experimental-report --report-on-fatalerror --report-on-signal --report-uncaught-exception
 'use strict';
 const common = require('../common');
-common.skipIfReportDisabled();
 const assert = require('assert');
 
 common.expectWarning('ExperimentalWarning',

diff --git a/test/report/test-report-fatal-error.js b/test/report/test-report-fatal-error.js
@@ -1,7 +1,6 @@
 'use strict';
 
 const common = require('../common');
-common.skipIfReportDisabled();
 const assert = require('assert');
 // Testcase to produce report on fatal error (javascript heap OOM)
 if (process.argv[2] === 'child') {

diff --git a/test/report/test-report-getreport.js b/test/report/test-report-getreport.js
@@ -1,7 +1,6 @@
 // Flags: --experimental-report
 'use strict';
 const common = require('../common');
-common.skipIfReportDisabled();
 const assert = require('assert');
 const helper = require('../common/report');
 

diff --git a/test/report/test-report-signal.js b/test/report/test-report-signal.js
@@ -2,7 +2,7 @@
 'use strict';
 // Test producing a report via signal.
 const common = require('../common');
-common.skipIfReportDisabled();
+
 if (common.isWindows)
   return common.skip('Unsupported on Windows.');
 

diff --git a/test/report/test-report-uncaught-exception.js b/test/report/test-report-uncaught-exception.js
@@ -2,7 +2,6 @@
 'use strict';
 // Test producing a report on uncaught exception.
 const common = require('../common');
-common.skipIfReportDisabled();
 const assert = require('assert');
 const helper = require('../common/report');
 const tmpdir = require('../common/tmpdir');

diff --git a/test/report/test-report-uv-handles.js b/test/report/test-report-uv-handles.js
@@ -5,7 +5,6 @@ const common = require('../common');
 if (common.isIBMi)
   common.skip('IBMi does not support fs.watch()');
 
-common.skipIfReportDisabled();
 if (process.argv[2] === 'child') {
   // Exit on loss of parent process
   const exit = () => process.exit(2);

diff --git a/test/report/test-report-worker.js b/test/report/test-report-worker.js
@@ -1,7 +1,6 @@
 // Flags: --experimental-report
 'use strict';
 const common = require('../common');
-common.skipIfReportDisabled();
 const assert = require('assert');
 const { Worker } = require('worker_threads');
 const { once } = require('events');

diff --git a/test/report/test-report-writereport.js b/test/report/test-report-writereport.js
@@ -3,7 +3,6 @@
 
 // Test producing a report via API call, using the no-hooks/no-signal interface.
 const common = require('../common');
-common.skipIfReportDisabled();
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const fs = require('fs');