lib: add success return bool in unsubscribe

nodejs · Oct 12, 2021 · 6d07e4d · 6d07e4d
1 parent 64fdae3
commit 6d07e4d
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/lib/diagnostics_channel.js b/lib/diagnostics_channel.js
@@ -32,15 +32,17 @@ class ActiveChannel {
 
   unsubscribe(subscription) {
     const index = ArrayPrototypeIndexOf(this._subscribers, subscription);
-    if (index >= 0) {
-      ArrayPrototypeSplice(this._subscribers, index, 1);
+    if (index === -1) return false;
 
-      // When there are no more active subscribers, restore to fast prototype.
-      if (!this._subscribers.length) {
-        // eslint-disable-next-line no-use-before-define
-        ObjectSetPrototypeOf(this, Channel.prototype);
-      }
+    ArrayPrototypeSplice(this._subscribers, index, 1);
+
+    // When there are no more active subscribers, restore to fast prototype.
+    if (!this._subscribers.length) {
+      // eslint-disable-next-line no-use-before-define
+      ObjectSetPrototypeOf(this, Channel.prototype);
     }
+
+    return true;
   }
 
   get hasSubscribers() {
@@ -79,7 +81,9 @@ class Channel {
     this.subscribe(subscription);
   }
 
-  unsubscribe() {}
+  unsubscribe() {
+    return false;
+  }
 
   get hasSubscribers() {
     return false;