readline: fix behaviour of Interface plugged to a non-terminal output

Fixes: #36773 PR-URL: #36774 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · May 1, 2021 · 70cbe4a · 70cbe4a
1 parent 1521a59
commit 70cbe4a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/lib/readline.js b/lib/readline.js
@@ -252,9 +252,6 @@ function Interface(input, output, completer, terminal) {
     input.on('keypress', onkeypress);
     input.on('end', ontermend);
 
-    // Current line
-    this.line = '';
-
     this._setRawMode(true);
     this.terminal = true;
 
@@ -270,6 +267,9 @@ function Interface(input, output, completer, terminal) {
     self.once('close', onSelfCloseWithTerminal);
   }
 
+  // Current line
+  this.line = '';
+
   input.resume();
 }
 

diff --git a/test/parallel/test-repl-no-terminal.js b/test/parallel/test-repl-no-terminal.js
@@ -0,0 +1,7 @@
+'use strict';
+const common = require('../common');
+
+const repl = require('repl');
+const r = repl.start({ terminal: false });
+r.setupHistory('/nonexistent/file', common.mustSucceed());
+process.stdin.unref?.();