Skip to content

Commit

Permalink
test: remove unnecessary common.platformTimeout() call
Browse files Browse the repository at this point in the history
Applying platformTimeout() to the interval is counterproductive. It
should be applied to the request timeout duration only.

PR-URL: #30677
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott committed Nov 29, 2019
1 parent 527ee38 commit 721076b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/sequential/test-http-server-consumed-timeout.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function runTest(timeoutDuration) {
const interval = setInterval(() => {
intervalWasInvoked = true;
req.write('a');
}, common.platformTimeout(25));
}, 25);
setTimeout(() => {
clearInterval(interval);
req.end();
Expand Down

0 comments on commit 721076b

Please sign in to comment.