fs: add validateBuffer to improve error

nodejs · Sep 24, 2022 · 73aaca6 · 73aaca6
1 parent abfeed8
commit 73aaca6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/fs.js b/lib/fs.js
@@ -619,6 +619,7 @@ function read(fd, buffer, offsetOrOptions, length, position, callback) {
         // This is fs.read(fd, params, callback)
         params = buffer;
         ({ buffer = Buffer.alloc(16384) } = params ?? kEmptyObject);
+        validateBuffer(buffer);
       }
       callback = offsetOrOptions;
     } else {

diff --git a/test/parallel/test-fs-read.js b/test/parallel/test-fs-read.js
@@ -79,7 +79,11 @@ assert.throws(
 
 assert.throws(
   () => fs.read(fd, { buffer: null }, common.mustNotCall()),
-  /TypeError: Cannot read properties of null \(reading 'byteLength'\)/,
+  {
+    name: 'TypeError',
+    message: 'The "buffer" argument must be an instance of Buffer, ' +
+    'TypedArray, or DataView. Received null',
+  },
   'throws when options.buffer is null'
 );