Skip to content

Commit

Permalink
test: fix test-cluster-net-listen-relative-path.js to run in /
Browse files Browse the repository at this point in the history
test-cluster-net-listen-relative-path fails if run from the root
directory on POSIX because the socket filename isn't quite long enough.
Increase it by 2 so that the path length always exceeds 100 characters.

PR-URL: #34820
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
  • Loading branch information
Trott committed Aug 20, 2020
1 parent 9fd71a9 commit 796317f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-cluster-net-listen-relative-path.js
Expand Up @@ -17,7 +17,7 @@ const tmpdir = require('../common/tmpdir');

// Choose a socket name such that the absolute path would exceed 100 bytes.
const socketDir = './unix-socket-dir';
const socketName = 'A'.repeat(100 - socketDir.length - 1);
const socketName = 'A'.repeat(101 - socketDir.length);

// Make sure we're not in a weird environment.
assert.ok(path.resolve(socketDir, socketName).length > 100,
Expand Down

0 comments on commit 796317f

Please sign in to comment.