fixup! src,lib: retrieve parsed source map url from v8

nodejs · Sep 29, 2022 · 86de757 · 86de757
1 parent df4e7df
commit 86de757
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/lib/internal/vm.js b/lib/internal/vm.js
@@ -22,7 +22,7 @@ const {
 } = require('internal/errors').codes;
 
 function isContext(object) {
-  validateObject(object, 'object', { allowArray: true });
+  validateObject(object, 'object', { __proto__: null, allowArray: true });
 
   return _isContext(object);
 }
@@ -68,7 +68,7 @@ function internalCompileFunction(code, params, options) {
   validateArray(contextExtensions, 'options.contextExtensions');
   ArrayPrototypeForEach(contextExtensions, (extension, i) => {
     const name = `options.contextExtensions[${i}]`;
-    validateObject(extension, name, { nullable: true });
+    validateObject(extension, name, { __proto__: null, nullable: true });
   });
 
   const result = compileFunction(

diff --git a/test/parallel/test-vm-source-map-url.js b/test/parallel/test-vm-source-map-url.js
@@ -0,0 +1,27 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const vm = require('vm');
+
+function checkSourceMapUrl(source, expectedSourceMapURL) {
+  const script = new vm.Script(source);
+  assert.strictEqual(script.sourceMapURL, expectedSourceMapURL);
+}
+
+// No magic comment
+checkSourceMapUrl(`
+function myFunc() {}
+`, undefined);
+
+// Malformed magic comment
+checkSourceMapUrl(`
+function myFunc() {}
+// sourceMappingURL=sourcemap.json
+`, undefined);
+
+// Expected magic comment
+checkSourceMapUrl(`
+function myFunc() {}
+//# sourceMappingURL=sourcemap.json
+`, 'sourcemap.json');