Skip to content

Commit

Permalink
quic: fix clang warning
Browse files Browse the repository at this point in the history
PR-URL: #33963
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
gengjiawen authored and jasnell committed Jun 22, 2020
1 parent 680644a commit 8ef86a9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/quic/node_quic_crypto.cc
Expand Up @@ -560,7 +560,9 @@ Local<Value> GetALPNProtocol(const QuicSession& session) {
QuicCryptoContext* ctx = session.crypto_context();
Environment* env = session.env();
std::string alpn = ctx->selected_alpn();
if (alpn == NGTCP2_ALPN_H3 + 1) {
// This supposed to be `NGTCP2_ALPN_H3 + 1`
// Details see https://github.com/nodejs/node/issues/33959
if (alpn == &NGTCP2_ALPN_H3[1]) {
return env->quic_alpn_string();
} else {
return ToV8Value(
Expand Down

0 comments on commit 8ef86a9

Please sign in to comment.