deps: V8: fix v8-cppgc.h for MSVC

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs · Nov 21, 2022 · 9348bdd · 9348bdd
1 parent e929254
commit 9348bdd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/common.gypi b/common.gypi
@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.1',
+    'v8_embedder_string': '-node.2',
 
     ##### V8 defaults for Node.js #####
 

diff --git a/deps/v8/include/v8-cppgc.h b/deps/v8/include/v8-cppgc.h
@@ -77,6 +77,9 @@ struct WrapperDescriptor final {
 };
 
 struct V8_EXPORT CppHeapCreateParams {
+  CppHeapCreateParams(const CppHeapCreateParams&) = delete;
+  CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete;
+
   std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
   WrapperDescriptor wrapper_descriptor;
   /**