Skip to content

Commit

Permalink
tools: add double-quotes to make-v8.sh
Browse files Browse the repository at this point in the history
Now that we maintain make-v8.sh rather than pull it from upstream, we
can make it conform to our shellcheck lint checks.

This is not being flagged in CI because (I'm guessing) shellcheck in CI
is 0.7.0 but latest is 0.8.0.
  • Loading branch information
Trott committed Dec 21, 2021
1 parent cf69964 commit 9f12461
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/make-v8.sh
Expand Up @@ -17,7 +17,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
fi
# set paths manually for now to use locally installed gn
export BUILD_TOOLS=/home/iojs/build-tools
export LD_LIBRARY_PATH=$BUILD_TOOLS:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH="$BUILD_TOOLS:$LD_LIBRARY_PATH"
# Avoid linking to ccache symbolic links as ccache decides which
# binary to run based on the name of the link (we always name them gcc/g++).
# shellcheck disable=SC2154
Expand All @@ -28,7 +28,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
rm -f "$BUILD_TOOLS/gcc"
ln -s "$CXX_PATH" "$BUILD_TOOLS/g++"
ln -s "$CC_PATH" "$BUILD_TOOLS/gcc"
export PATH=$BUILD_TOOLS:$PATH
export PATH="$BUILD_TOOLS:$PATH"

g++ --version
gcc --version
Expand Down

0 comments on commit 9f12461

Please sign in to comment.