Skip to content

Commit

Permalink
deps: update ada to 2.5.1
Browse files Browse the repository at this point in the history
PR-URL: #48319
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
nodejs-github-bot authored and ruyadorno committed Aug 29, 2023
1 parent f302286 commit a2964a4
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
2 changes: 1 addition & 1 deletion deps/ada/ada.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* auto-generated on 2023-05-25 16:09:25 -0400. Do not edit! */
/* auto-generated on 2023-06-03 12:40:57 -0400. Do not edit! */
/* begin file src/ada.cpp */
#include "ada.h"
/* begin file src/checkers.cpp */
Expand Down
19 changes: 14 additions & 5 deletions deps/ada/ada.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* auto-generated on 2023-05-25 16:09:25 -0400. Do not edit! */
/* auto-generated on 2023-06-03 12:40:57 -0400. Do not edit! */
/* begin file include/ada.h */
/**
* @file ada.h
Expand Down Expand Up @@ -5544,7 +5544,11 @@ ada_really_inline size_t url::parse_port(std::string_view view,
}
ada_log("parse_port: is_valid = ", is_valid);
if (is_valid) {
port = (r.ec == std::errc() && scheme_default_port() != parsed_port)
// scheme_default_port can return 0, and we should allow 0 as a base port.
auto default_port = scheme_default_port();
bool is_port_valid = (default_port == 0 && parsed_port == 0) ||
(default_port != parsed_port);
port = (r.ec == std::errc() && is_port_valid)
? std::optional<uint16_t>(parsed_port)
: std::nullopt;
}
Expand Down Expand Up @@ -6428,7 +6432,12 @@ ada_really_inline size_t url_aggregator::parse_port(
}
ada_log("parse_port: is_valid = ", is_valid);
if (is_valid) {
if (r.ec == std::errc() && scheme_default_port() != parsed_port) {
ada_log("parse_port", r.ec == std::errc());
// scheme_default_port can return 0, and we should allow 0 as a base port.
auto default_port = scheme_default_port();
bool is_port_valid = (default_port == 0 && parsed_port == 0) ||
(default_port != parsed_port);
if (r.ec == std::errc() && is_port_valid) {
update_base_port(parsed_port);
} else {
clear_port();
Expand Down Expand Up @@ -6485,14 +6494,14 @@ inline std::ostream &operator<<(std::ostream &out,
#ifndef ADA_ADA_VERSION_H
#define ADA_ADA_VERSION_H

#define ADA_VERSION "2.5.0"
#define ADA_VERSION "2.5.1"

namespace ada {

enum {
ADA_VERSION_MAJOR = 2,
ADA_VERSION_MINOR = 5,
ADA_VERSION_REVISION = 0,
ADA_VERSION_REVISION = 1,
};

} // namespace ada
Expand Down

0 comments on commit a2964a4

Please sign in to comment.