Skip to content

Commit

Permalink
n-api: fix memory leak in napi_async_destroy()
Browse files Browse the repository at this point in the history
Backport-PR-URL: #19265
PR-URL: #17714
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
alnyan authored and MylesBorins committed May 1, 2018
1 parent 2e100c8 commit a744535
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/node_api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2770,6 +2770,8 @@ napi_status napi_async_destroy(napi_env env,
reinterpret_cast<node::async_context*>(async_context);
node::EmitAsyncDestroy(isolate, *node_async_context);

delete node_async_context;

return napi_clear_last_error(env);
}

Expand Down

0 comments on commit a744535

Please sign in to comment.