Skip to content

Commit

Permalink
src: remove kEagerCompile for CompileFunction
Browse files Browse the repository at this point in the history
It wasn't doing anything, and actually enabling it would cause some
tests to fail.

Refs: #48576
PR-URL: #48671
Refs: v8/v8@cb00db4
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
kvakil authored and ruyadorno committed Sep 11, 2023
1 parent 6e2cbe0 commit ae11d1e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/node_builtins.cc
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
const bool has_cache = cached_data != nullptr;
ScriptCompiler::CompileOptions options =
has_cache ? ScriptCompiler::kConsumeCodeCache
: ScriptCompiler::kEagerCompile;
: ScriptCompiler::kNoCompileOptions;
ScriptCompiler::Source script_source(source, origin, cached_data);

per_process::Debug(DebugCategory::CODE_CACHE,
Expand Down
2 changes: 1 addition & 1 deletion src/node_snapshotable.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,7 @@ void CompileSerializeMain(const FunctionCallbackInfo<Value>& args) {
parameters.data(),
0,
nullptr,
ScriptCompiler::kEagerCompile)
ScriptCompiler::kNoCompileOptions)
.ToLocal(&fn)) {
args.GetReturnValue().Set(fn);
}
Expand Down

0 comments on commit ae11d1e

Please sign in to comment.