Skip to content

Commit

Permalink
src: make edge names in BaseObjects more descriptive in heap snapshots
Browse files Browse the repository at this point in the history
Previously these were named "wrapper" and "wrapped", which can be
somewhat difficult to understand. This patch renames them to
"javascript_to_native" and "native_to_javascript".
  • Loading branch information
joyeecheung committed Feb 4, 2023
1 parent b8b92ca commit ae4391e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/memory_tracker-inl.h
Expand Up @@ -318,8 +318,8 @@ MemoryRetainerNode* MemoryTracker::AddNode(const MemoryRetainer* retainer,
if (CurrentNode() != nullptr) graph_->AddEdge(CurrentNode(), n, edge_name);

if (n->JSWrapperNode() != nullptr) {
graph_->AddEdge(n, n->JSWrapperNode(), "wrapped");
graph_->AddEdge(n->JSWrapperNode(), n, "wrapper");
graph_->AddEdge(n, n->JSWrapperNode(), "native_to_javascript");
graph_->AddEdge(n->JSWrapperNode(), n, "javascript_to_native");
}

return n;
Expand Down

0 comments on commit ae4391e

Please sign in to comment.