events: set target property to null

PR-URL: #33615 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
nodejs · May 31, 2020 · b2b95eb · b2b95eb
1 parent 07dcb75
commit b2b95eb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -64,6 +64,7 @@ class Event {
       enumerable: true,
       configurable: false
     });
+    this[kTarget] = null;
   }
 
   [customInspectSymbol](depth, options) {
@@ -245,7 +246,7 @@ class EventTarget {
     }
 
     if (this.#emitting.has(event.type) ||
-        event[kTarget] !== undefined) {
+        event[kTarget] !== null) {
       throw new ERR_EVENT_RECURSION(event.type);
     }
 

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -385,6 +385,7 @@ const ev = new Event('foo');
 {
   const target = new EventTarget();
   const event = new Event('foo');
+  strictEqual(event.target, null);
   target.addEventListener('foo', common.mustCall((event) => {
     strictEqual(event.target, target);
     strictEqual(event.currentTarget, target);