fs: fix callback with error if SyncWriteStream writeSync failed

Catch SyncWriteStream write file error. Fixes: #47948
nodejs · May 10, 2023 · c5b5375 · c5b5375
1 parent 0736d0b
commit c5b5375
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/internal/fs/sync_write_stream.js b/lib/internal/fs/sync_write_stream.js
@@ -23,8 +23,12 @@ ObjectSetPrototypeOf(SyncWriteStream.prototype, Writable.prototype);
 ObjectSetPrototypeOf(SyncWriteStream, Writable);
 
 SyncWriteStream.prototype._write = function(chunk, encoding, cb) {
-  writeSync(this.fd, chunk, 0, chunk.length);
-  cb();
+  try {
+    writeSync(this.fd, chunk, 0, chunk.length);
+    cb();
+  } catch (e) {
+    cb(e);
+  }
   return true;
 };
 

diff --git a/test/parallel/test-internal-fs-syncwritestream.js b/test/parallel/test-internal-fs-syncwritestream.js
@@ -74,3 +74,15 @@ const filename = path.join(tmpdir.path, 'sync-write-stream.txt');
     assert.strictEqual(stream.fd, null);
   }));
 }
+
+// Verify write file failed trigger error event
+{
+  const fd = fs.openSync(filename, 'w');
+  const stream = new SyncWriteStream(fd);
+
+  assert.strictEqual(stream.fd, fd);
+  stream.on('error', common.mustCall());
+  stream._write({}, common.mustCall((err) => {
+    assert(err);
+  }));
+}