test: use --port=0 in debugger tests that do not have to work on 9229

To avoid failures when there is another running process occupying the port 9229 which may happen if there is a stale process, use the --port argument of node-inspect to use a random port in tests that don't have to work on port 9229. The following tests are not touched: - test-debugger-launch: specifically needs to test port 9229 - test-debugger-pid: needs modifications to node-inspect - test-debugger-random-port-with-inspect-port: same as -pid test
nodejs · Aug 22, 2022 · c9b3ff7 · c9b3ff7
1 parent fd07bab
commit c9b3ff7
Show file tree

Hide file tree

Showing 23 changed files with 23 additions and 23 deletions.
diff --git a/test/sequential/test-debugger-auto-resume.js b/test/sequential/test-debugger-auto-resume.js
@@ -20,7 +20,7 @@ addLibraryPath(process.env);
   const env = { ...process.env };
   env.NODE_INSPECT_RESUME_ON_START = '1';
 
-  const cli = startCLI([script], [], { env });
+  const cli = startCLI(['--port=0', script], [], { env });
 
   cli.waitForInitialBreak()
     .then(() => {

diff --git a/test/sequential/test-debugger-backtrace.js b/test/sequential/test-debugger-backtrace.js
@@ -13,7 +13,7 @@ const path = require('path');
 {
   const scriptFullPath = fixtures.path('debugger', 'backtrace.js');
   const script = path.relative(process.cwd(), scriptFullPath);
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-break.js b/test/sequential/test-debugger-break.js
@@ -13,7 +13,7 @@ const path = require('path');
 {
   const scriptFullPath = fixtures.path('debugger', 'break.js');
   const script = path.relative(process.cwd(), scriptFullPath);
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-breakpoint-exists.js b/test/sequential/test-debugger-breakpoint-exists.js
@@ -10,7 +10,7 @@ const startCLI = require('../common/debugger');
 // Test for "Breakpoint at specified location already exists" error.
 {
   const script = fixtures.path('debugger', 'three-lines.js');
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-clear-breakpoints.js b/test/sequential/test-debugger-clear-breakpoints.js
@@ -13,7 +13,7 @@ const path = require('path');
 {
   const scriptFullPath = fixtures.path('debugger', 'break.js');
   const script = path.relative(process.cwd(), scriptFullPath);
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-exceptions.js b/test/sequential/test-debugger-exceptions.js
@@ -13,7 +13,7 @@ const path = require('path');
 {
   const scriptFullPath = fixtures.path('debugger', 'exceptions.js');
   const script = path.relative(process.cwd(), scriptFullPath);
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-exec-scope.js b/test/sequential/test-debugger-exec-scope.js
@@ -10,7 +10,7 @@ const assert = require('assert');
 
 // exec .scope
 {
-  const cli = startCLI([fixtures.path('debugger/backtrace.js')]);
+  const cli = startCLI(['--port=0', fixtures.path('debugger/backtrace.js')]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-exec.js b/test/sequential/test-debugger-exec.js
@@ -10,7 +10,7 @@ const assert = require('assert');
 
 {
 
-  const cli = startCLI([fixtures.path('debugger/alive.js')]);
+  const cli = startCLI(['--port=0', fixtures.path('debugger/alive.js')]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-heap-profiler.js b/test/sequential/test-debugger-heap-profiler.js
@@ -17,7 +17,7 @@ const filename = path.join(tmpdir.path, 'node.heapsnapshot');
 // Heap profiler take snapshot.
 {
   const opts = { cwd: tmpdir.path };
-  const cli = startCLI([fixtures.path('debugger/empty.js')], [], opts);
+  const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')], [], opts);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-help.js b/test/sequential/test-debugger-help.js
@@ -9,7 +9,7 @@ const startCLI = require('../common/debugger');
 const assert = require('assert');
 
 {
-  const cli = startCLI([fixtures.path('debugger/empty.js')]);
+  const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-list.js b/test/sequential/test-debugger-list.js
@@ -8,7 +8,7 @@ const startCLI = require('../common/debugger');
 
 const assert = require('assert');
 
-const cli = startCLI([fixtures.path('debugger/three-lines.js')]);
+const cli = startCLI(['--port=0', fixtures.path('debugger/three-lines.js')]);
 
 (async () => {
   await cli.waitForInitialBreak();

diff --git a/test/sequential/test-debugger-low-level.js b/test/sequential/test-debugger-low-level.js
@@ -9,7 +9,7 @@ const assert = require('assert');
 
 // Debugger agent direct access.
 {
-  const cli = startCLI([fixtures.path('debugger/three-lines.js')]);
+  const cli = startCLI(['--port=0', fixtures.path('debugger/three-lines.js')]);
   const scriptPattern = /^\* (\d+): \S+debugger(?:\/|\\)three-lines\.js/m;
 
   function onFatal(error) {

diff --git a/test/sequential/test-debugger-object-type-remote-object.js b/test/sequential/test-debugger-object-type-remote-object.js
@@ -8,7 +8,7 @@ const startCLI = require('../common/debugger');
 
 const assert = require('assert');
 
-const cli = startCLI([fixtures.path('debugger/empty.js')]);
+const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
 
 (async () => {
   await cli.waitForInitialBreak();

diff --git a/test/sequential/test-debugger-pid.js b/test/sequential/test-debugger-pid.js
@@ -35,7 +35,7 @@ function launchTarget(...args) {
   return launchTarget(script)
     .then((childProc) => {
       target = childProc;
-      cli = startCLI(['-p', `${target.pid}`]);
+      cli = startCLI(['--port=0', '-p', `${target.pid}`]);
       return cli.waitForPrompt();
     })
     .then(() => cli.command('sb("alive.js", 3)'))

diff --git a/test/sequential/test-debugger-preserve-breaks.js b/test/sequential/test-debugger-preserve-breaks.js
@@ -13,7 +13,7 @@ const path = require('path');
 {
   const scriptFullPath = fixtures.path('debugger', 'three-lines.js');
   const script = path.relative(process.cwd(), scriptFullPath);
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-profile-command.js b/test/sequential/test-debugger-profile-command.js
@@ -10,7 +10,7 @@ const assert = require('assert');
 const fs = require('fs');
 const path = require('path');
 
-const cli = startCLI([fixtures.path('debugger/empty.js')]);
+const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
 
 const rootDir = path.resolve(__dirname, '..', '..');
 

diff --git a/test/sequential/test-debugger-profile.js b/test/sequential/test-debugger-profile.js
@@ -14,7 +14,7 @@ function delay(ms) {
 
 // Profiles.
 {
-  const cli = startCLI([fixtures.path('debugger/empty.js')]);
+  const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-restart-message.js b/test/sequential/test-debugger-restart-message.js
@@ -14,7 +14,7 @@ const startCLI = require('../common/debugger');
 // Using `restart` should result in only one "Connect/For help" message.
 {
   const script = fixtures.path('debugger', 'three-lines.js');
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-run-after-quit-restart.js b/test/sequential/test-debugger-run-after-quit-restart.js
@@ -13,7 +13,7 @@ const path = require('path');
 {
   const scriptFullPath = fixtures.path('debugger', 'three-lines.js');
   const script = path.relative(process.cwd(), scriptFullPath);
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-sb-before-load.js b/test/sequential/test-debugger-sb-before-load.js
@@ -17,7 +17,7 @@ const path = require('path');
   const otherScriptFullPath = fixtures.path('debugger', 'cjs', 'other.js');
   const otherScript = path.relative(process.cwd(), otherScriptFullPath);
 
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-scripts.js b/test/sequential/test-debugger-scripts.js
@@ -11,7 +11,7 @@ const assert = require('assert');
 // List scripts.
 {
   const script = fixtures.path('debugger', 'three-lines.js');
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-use-strict.js b/test/sequential/test-debugger-use-strict.js
@@ -11,7 +11,7 @@ const assert = require('assert');
 // Test for files that start with strict directive.
 {
   const script = fixtures.path('debugger', 'use-strict.js');
-  const cli = startCLI([script]);
+  const cli = startCLI(['--port=0', script]);
 
   function onFatal(error) {
     cli.quit();

diff --git a/test/sequential/test-debugger-watchers.js b/test/sequential/test-debugger-watchers.js
@@ -10,7 +10,7 @@ const assert = require('assert');
 
 // Stepping through breakpoints.
 {
-  const cli = startCLI([fixtures.path('debugger/break.js')]);
+  const cli = startCLI(['--port=0', fixtures.path('debugger/break.js')]);
 
   function onFatal(error) {
     cli.quit();