lib: use kEmptyObject as default value for options

`kEmptyObject` is more suitable than {} if options don't need mutation.
nodejs · Dec 29, 2022 · cab08ea · cab08ea
1 parent 4830a6c
commit cab08ea
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/lib/events.js b/lib/events.js
@@ -1013,7 +1013,7 @@ function eventTargetAgnosticAddListener(emitter, name, listener, flags) {
  *   }} [options]
  * @returns {AsyncIterator}
  */
-function on(emitter, event, options = {}) {
+function on(emitter, event, options = kEmptyObject) {
   // Parameters validation
   const signal = options.signal;
   validateAbortSignal(signal, 'options.signal');

diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js
@@ -37,6 +37,8 @@ const {
 
 const { toNamespacedPath } = require('path');
 
+const { kEmptyObject } = require('internal/util');
+
 const {
   validateAbortSignal,
   validateBoolean,
@@ -296,7 +298,7 @@ ObjectDefineProperty(FSEvent.prototype, 'owner', {
   set(v) { return this[owner_symbol] = v; }
 });
 
-async function* watch(filename, options = {}) {
+async function* watch(filename, options = kEmptyObject) {
   const path = toNamespacedPath(getValidatedPath(filename));
   validateObject(options, 'options');
 

diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -3326,7 +3326,7 @@ function createSecureServer(options, handler) {
 function createServer(options, handler) {
   if (typeof options === 'function') {
     handler = options;
-    options = {};
+    options = kEmptyObject;
   }
   return new Http2Server(options, handler);
 }

diff --git a/lib/internal/socketaddress.js b/lib/internal/socketaddress.js
@@ -11,6 +11,8 @@ const {
   AF_INET6,
 } = internalBinding('block_list');
 
+const { kEmptyObject } = require('internal/util');
+
 const {
   validateObject,
   validateString,
@@ -44,7 +46,7 @@ class SocketAddress extends JSTransferable {
     return value?.[kHandle] !== undefined;
   }
 
-  constructor(options = {}) {
+  constructor(options = kEmptyObject) {
     super();
     validateObject(options, 'options');
     let { family = 'ipv4' } = options;

diff --git a/lib/net.js b/lib/net.js
@@ -108,6 +108,7 @@ const {
 } = require('internal/errors');
 const { isUint8Array } = require('internal/util/types');
 const { queueMicrotask } = require('internal/process/task_queues');
+const { kEmptyObject } = require('internal/util');
 const {
   validateAbortSignal,
   validateBoolean,
@@ -1584,7 +1585,7 @@ function Server(options, connectionListener) {
 
   if (typeof options === 'function') {
     connectionListener = options;
-    options = {};
+    options = kEmptyObject;
     this.on('connection', connectionListener);
   } else if (options == null || typeof options === 'object') {
     options = { ...options };