fixup! module: fix the leak in SourceTextModule and ContextifySript

nodejs · Sep 26, 2023 · cbafa9c · cbafa9c
1 parent 3f9dce6
commit cbafa9c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/module_wrap.cc b/src/module_wrap.cc
@@ -58,7 +58,7 @@ ModuleWrap::ModuleWrap(Environment* env,
     : BaseObject(env, object),
       module_(env->isolate(), module),
       module_hash_(module->GetIdentityHash()) {
-  object->SetInternalField(kModuleSlot, module);
+  object->SetInternalFieldForNodeCore(kModuleSlot, module);
   object->SetInternalField(kURLSlot, url);
   object->SetInternalField(kSyntheticEvaluationStepsSlot,
                            synthetic_evaluation_step);

diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -858,7 +858,8 @@ void ContextifyScript::New(const FunctionCallbackInfo<Value>& args) {
 
   contextify_script->script_.Reset(isolate, v8_script);
   contextify_script->script_.SetWeak();
-  contextify_script->object()->SetInternalField(kUnboundScriptSlot, v8_script);
+  contextify_script->object()->SetInternalFieldForNodeCore(kUnboundScriptSlot,
+                                                           v8_script);
 
   std::unique_ptr<ScriptCompiler::CachedData> new_cached_data;
   if (produce_cached_data) {