Skip to content

Commit

Permalink
stream: revert revert map spec compliance
Browse files Browse the repository at this point in the history
This reverts commit 91d28d8.

PR-URL: #41933
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
benjamingr committed Feb 13, 2022
1 parent 829a34a commit ceaa299
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/stream.js
Expand Up @@ -69,7 +69,7 @@ for (const key of ObjectKeys(streamReturningOperators)) {
value: fn,
enumerable: false,
configurable: true,
writable: true,
writable: false,
});
}
for (const key of ObjectKeys(promiseReturningOperators)) {
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-stream-iterator-helpers-test262-tests.mjs
Expand Up @@ -68,7 +68,7 @@ import assert from 'assert';
);
assert.strictEqual(descriptor.enumerable, false);
assert.strictEqual(descriptor.configurable, true);
// assert.strictEqual(descriptor.writable, false);
assert.strictEqual(descriptor.writable, false);
}
{
// drop/length
Expand All @@ -79,7 +79,7 @@ import assert from 'assert';
);
assert.strictEqual(descriptor.enumerable, false);
assert.strictEqual(descriptor.configurable, true);
// assert.strictEqual(descriptor.writable, false);
assert.strictEqual(descriptor.writable, false);
// drop/limit-equals-total
const iterator = Readable.from([1, 2]).drop(2);
const result = await iterator[Symbol.asyncIterator]().next();
Expand Down

0 comments on commit ceaa299

Please sign in to comment.