fixup! lib: make safe primordials safe to iterate

nodejs · Dec 7, 2020 · cf53748 · cf53748
1 parent 6a4e2ab
commit cf53748
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/internal/per_context/primordials.js b/lib/internal/per_context/primordials.js
@@ -84,9 +84,7 @@ const createSafeIterator = (factory, next) => {
   Object.setPrototypeOf(SafeIterator.prototype, null);
   Object.freeze(SafeIterator.prototype);
   Object.freeze(SafeIterator);
-  return function() {
-    return new SafeIterator(this);
-  };
+  return SafeIterator;
 };
 
 function makeSafe(unsafe, safe) {
@@ -95,7 +93,10 @@ function makeSafe(unsafe, safe) {
   if (Symbol.iterator in unsafe.prototype) {
     const createIterator = uncurryThis(unsafe.prototype[Symbol.iterator]);
     const next = uncurryThis(createIterator(new unsafe()).next);
-    safe.prototype[Symbol.iterator] = createSafeIterator(createIterator, next);
+    const SafeIterator = createSafeIterator(createIterator, next);
+    safe.prototype[Symbol.iterator] = function() {
+      return new SafeIterator(this);
+    };
   }
   Object.setPrototypeOf(safe.prototype, null);
   Object.freeze(safe.prototype);