Skip to content

Commit

Permalink
benchmark: fix build warnings
Browse files Browse the repository at this point in the history
The napi/* benchmarks were using an incorrect signature for the V8
add-on init function. This was causing a warning.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #36157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
  • Loading branch information
Gabriel Schulhof authored and BethGriggs committed Dec 15, 2020
1 parent 127a4fb commit d49e0ca
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion benchmark/napi/function_args/binding.cc
Expand Up @@ -123,7 +123,9 @@ void CallWithArguments(const FunctionCallbackInfo<Value>& args) {
}
}

void Initialize(Local<Object> target) {
void Initialize(Local<Object> target,
Local<Value> module,
void* data) {
NODE_SET_METHOD(target, "callWithString", CallWithString);
NODE_SET_METHOD(target, "callWithLongString", CallWithString);

Expand Down
4 changes: 3 additions & 1 deletion benchmark/napi/function_call/binding.cc
Expand Up @@ -7,7 +7,9 @@ void Hello(const v8::FunctionCallbackInfo<v8::Value>& args) {
args.GetReturnValue().Set(c++);
}

void Initialize(v8::Local<v8::Object> target) {
void Initialize(v8::Local<v8::Object> target,
v8::Local<v8::Value> module,
void* data) {
NODE_SET_METHOD(target, "hello", Hello);
}

Expand Down

0 comments on commit d49e0ca

Please sign in to comment.