src: use a higher limit in the NearHeapLimitCallback

V8 requires the NearHeapLimitCallback to return a limit that's higher than the initial one or otherwise it will crash.
nodejs · Nov 30, 2021 · d4ac494 · d4ac494
1 parent d9de812
commit d4ac494
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/env.cc b/src/env.cc
@@ -1631,7 +1631,10 @@ size_t Environment::NearHeapLimitCallback(void* data,
   env->isolate()->AutomaticallyRestoreInitialHeapLimit(0.95);
 
   env->is_processing_heap_limit_callback_ = false;
-  return initial_heap_limit;
+
+  // The new limit must be higher than initial_heap_limit or V8 might
+  // crash.
+  return initial_heap_limit + 1;
 }
 
 inline size_t Environment::SelfSize() const {