Skip to content

Commit

Permalink
test: recognize wpt completion error
Browse files Browse the repository at this point in the history
PR-URL: #50429
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
  • Loading branch information
legendecas authored and targos committed Nov 11, 2023
1 parent 4c93f96 commit dadf77c
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 0 deletions.
10 changes: 10 additions & 0 deletions test/common/wpt.js
Original file line number Diff line number Diff line change
Expand Up @@ -838,6 +838,16 @@ class WPTRunner {
this.fail(spec, { name: 'WPT testharness timeout' }, kTimeout);
// Mark the whole test as TIMEOUT in wpt.fyi report.
reportResult?.finish('TIMEOUT');
} else if (status !== kPass) {
// No need to record this synthetic failure with wpt.fyi.
this.fail(spec, {
status: status,
name: 'WPT test harness error',
message: harnessStatus.message,
stack: harnessStatus.stack,
}, status);
// Mark the whole test as ERROR in wpt.fyi report.
reportResult?.finish('ERROR');
} else {
reportResult?.finish();
}
Expand Down
3 changes: 3 additions & 0 deletions test/wpt/status/console.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,8 @@
"console namespace: operation dir(optional any, optional object?)"
]
}
},
"idlharness-shadowrealm.window.js": {
"skip": "ShadowRealm support is not enabled"
}
}
3 changes: 3 additions & 0 deletions test/wpt/status/encoding.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@
"idlharness.any.js": {
"skip": "No implementation of TextDecoderStream and TextEncoderStream"
},
"idlharness-shadowrealm.window.js": {
"skip": "ShadowRealm support is not enabled"
},
"replacement-encodings.any.js": {
"skip": "decoding-helpers.js needs XMLHttpRequest"
},
Expand Down
3 changes: 3 additions & 0 deletions test/wpt/status/hr-time.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
]
}
},
"idlharness-shadowrealm.window.js": {
"skip": "ShadowRealm support is not enabled"
},
"window-worker-timeOrigin.window.js": {
"skip": "depends on URL.createObjectURL(blob)"
}
Expand Down
3 changes: 3 additions & 0 deletions test/wpt/status/streams.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
]
}
},
"idlharness-shadowrealm.window.js": {
"skip": "ShadowRealm support is not enabled"
},
"piping/general-addition.any.js": {
"fail": {
"expected": [
Expand Down
3 changes: 3 additions & 0 deletions test/wpt/status/url.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"idlharness-shadowrealm.window.js": {
"skip": "ShadowRealm support is not enabled"
},
"percent-encoding.window.js": {
"skip": "TODO: port from .window.js"
},
Expand Down
3 changes: 3 additions & 0 deletions test/wpt/status/user-timing.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"idlharness-shadowrealm.window.js": {
"skip": "ShadowRealm support is not enabled"
},
"invoke_with_timing_attributes.worker.js": {
"skip": "importScripts not supported"
},
Expand Down

0 comments on commit dadf77c

Please sign in to comment.