fixup! events: refactor to use more primordials

nodejs · Dec 18, 2020 · df98f27 · df98f27
1 parent 9863b29
commit df98f27
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/events.js b/lib/events.js
@@ -554,7 +554,7 @@ EventEmitter.prototype.removeListener =
           return this;
 
         if (position === 0)
-          ArrayPrototypeShift(list);
+          list.shift();
         else {
           if (spliceOne === undefined)
             spliceOne = require('internal/util').spliceOne;
@@ -803,7 +803,7 @@ function on(emitter, event, options) {
   const iterator = ObjectSetPrototypeOf({
     next() {
       // First, we consume all unread events
-      const value = ArrayPrototypeShift(unconsumedEvents);
+      const value = unconsumedEvents.shift();
       if (value) {
         return PromiseResolve(createIterResult(value, false));
       }
@@ -885,7 +885,7 @@ function on(emitter, event, options) {
   }
 
   function eventHandler(...args) {
-    const promise = ArrayPrototypeShift(unconsumedPromises);
+    const promise = unconsumedPromises.shift();
     if (promise) {
       promise.resolve(createIterResult(args, false));
     } else {
@@ -896,7 +896,7 @@ function on(emitter, event, options) {
   function errorHandler(err) {
     finished = true;
 
-    const toError = ArrayPrototypeShift(unconsumedPromises);
+    const toError = unconsumedPromises.shift();
 
     if (toError) {
       toError.reject(err);