Skip to content

Commit

Permalink
tools: require more trailing commas
Browse files Browse the repository at this point in the history
All of the import and export statements in the codebase already use
trailing commas, this commit adds a linter rule to enforce that.

PR-URL: #46346
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
aduh95 authored and juanarbol committed Mar 3, 2023
1 parent 88614c5 commit e4756a8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions benchmark/.eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ env:
rules:
comma-dangle: [error, {
arrays: always-multiline,
exports: only-multiline,
exports: always-multiline,
functions: only-multiline,
imports: only-multiline,
imports: always-multiline,
objects: only-multiline,
}]
prefer-arrow-callback: error
4 changes: 2 additions & 2 deletions lib/.eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ env:
rules:
comma-dangle: [error, {
arrays: always-multiline,
exports: only-multiline,
exports: always-multiline,
functions: only-multiline,
imports: only-multiline,
imports: always-multiline,
objects: only-multiline,
}]
prefer-object-spread: error
Expand Down
4 changes: 2 additions & 2 deletions test/.eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ overrides:
rules:
comma-dangle: [error, {
arrays: always-multiline,
exports: only-multiline,
exports: always-multiline,
functions: only-multiline,
imports: only-multiline,
imports: always-multiline,
objects: only-multiline,
}]

0 comments on commit e4756a8

Please sign in to comment.