Skip to content

Commit

Permalink
test: fixup failing test/internet/test-dns.js
Browse files Browse the repository at this point in the history
The `ttl` for the `nodejs.org` DNS record is returning `0`
currently. The test checks for `> 0`, causing the test to
fail.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #38241
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
jasnell authored and targos committed May 1, 2021
1 parent 9265027 commit ea1183c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/internet/test-dns.js
Expand Up @@ -91,7 +91,7 @@ TEST(async function test_resolve4_ttl(done) {
assert.strictEqual(typeof item, 'object');
assert.strictEqual(typeof item.ttl, 'number');
assert.strictEqual(typeof item.address, 'string');
assert.ok(item.ttl > 0);
assert.ok(item.ttl >= 0);
assert.ok(isIPv4(item.address));
}
}
Expand Down Expand Up @@ -119,7 +119,7 @@ TEST(async function test_resolve6_ttl(done) {
assert.strictEqual(typeof item, 'object');
assert.strictEqual(typeof item.ttl, 'number');
assert.strictEqual(typeof item.address, 'string');
assert.ok(item.ttl > 0);
assert.ok(item.ttl >= 0);
assert.ok(isIPv6(item.address));
}
}
Expand Down

0 comments on commit ea1183c

Please sign in to comment.