Skip to content

Commit

Permalink
fixup! fixup! fixup! deps: update ICU to 72.1
Browse files Browse the repository at this point in the history
  • Loading branch information
targos committed Oct 20, 2022
1 parent 27dd1c4 commit f347c53
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/parallel/test-intl.js
Expand Up @@ -97,7 +97,11 @@ if (!common.hasIntl) {
// Test format
{
const localeString = date0.toLocaleString(['en'], optsGMT);
assert.strictEqual(localeString, '1/1/1970, 12:00:00 AM');
if (Number(process.versions.cldr) >= 42) {

This comment has been minimized.

Copy link
@srl295

srl295 Oct 20, 2022

Member

or better ===

This comment has been minimized.

Copy link
@targos

targos Oct 20, 2022

Author Member

But then when version 43 is released we will have to update this condition. And again with every new version, no?

This comment has been minimized.

Copy link
@srl295

srl295 Oct 20, 2022

Member

When 43 is released then you will need a new test with new requirements. But we can't predict what those will be.

This comment has been minimized.

Copy link
@targos

targos Oct 21, 2022

Author Member

We can't predict it, but I'd rather not have to update the test if the requirements are the same.

This comment has been minimized.

Copy link
@srl295

srl295 Oct 21, 2022

Member

@targos I'm still not clear on the point of the test. What are you trying to test?

This comment has been minimized.

Copy link
@targos

targos Oct 21, 2022

Author Member

I don't really know. My guess is that we want to avoid obvious regressions with Intl APIs (identify V8 bugs or wrong configuration of ICU?)

assert.strictEqual(localeString, '1/1/1970, 12:00:00 AM');
} else {
assert.strictEqual(localeString, '1/1/1970, 12:00:00 AM');
}
}
// number format
{
Expand Down

0 comments on commit f347c53

Please sign in to comment.