Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: need to upgrade tools/cpp_lint.py to be Python 3 compatible #25760

Closed
cclauss opened this issue Jan 28, 2019 · 3 comments · Fixed by #25771
Closed

tools: need to upgrade tools/cpp_lint.py to be Python 3 compatible #25760

cclauss opened this issue Jan 28, 2019 · 3 comments · Fixed by #25771

Comments

@cclauss
Copy link
Contributor

cclauss commented Jan 28, 2019 •
edited

Similar to #7462 but for Python 3 compatibility @bnoordhuis @thefourtheye

Upstream could be either:

Discovered via #25759 --> https://travis-ci.com/nodejs/node/jobs/173399622#L498

Running C++ linter on addon docs...
Traceback (most recent call last):
  File "tools/cpplint.py", line 6526, in <module>
    main()
  File "tools/cpplint.py", line 6510, in main
    ProcessFile(filename.decode('utf-8'), _cpplint_state.verbose_level)
AttributeError: 'str' object has no attribute 'decode'
  • Version:
  • Platform:
  • Subsystem:
@thefourtheye
Copy link
Contributor

We have diverged a little bit from the upstream, I believe. I am not sure if it would be okay to float a patch to fix this. @addaleax @bnoordhuis What do you think?

@cclauss cclauss mentioned this issue Jan 28, 2019
Closed
4 tasks
@cclauss
Copy link
Contributor Author

cclauss commented Jan 28, 2019

@refack

@refack
Copy link
Contributor

refack commented Jan 28, 2019 •
edited

Our history (fee4d3a) indicates that our best upstream is https://github.com/cpplint/cpplint/blob/master/cpplint.py, which is was made to be python3 compatible.
PR on it's way.

@refack refack mentioned this issue Jan 28, 2019
Merged
4 tasks
@cclauss cclauss mentioned this issue Jan 29, 2019
Closed
63 tasks
refack added a commit to refack/node that referenced this issue Jan 30, 2019
@refack
tools: bump cpplint.py to 3d8f6f876d
3dca9e0 
PR-URL: nodejs#25771
Fixes: nodejs#25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack added a commit to refack/node that referenced this issue Jan 30, 2019
@refack
tools: refloat Node.js patches to cpplint.py
4d19300 
* Preserve 3 node-core checks
* Preserve patch to `FileInfo.RepositoryName`
* Remove TAP to logfile (unused)

PR-URL: nodejs#25771
Fixes: nodejs#25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax pushed a commit that referenced this issue Feb 1, 2019
@refack @addaleax
tools: bump cpplint.py to 3d8f6f876d
b9289f4 
PR-URL: #25771
Fixes: #25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax pushed a commit that referenced this issue Feb 1, 2019
@refack @addaleax
tools: refloat Node.js patches to cpplint.py
454278a 
* Preserve 3 node-core checks
* Preserve patch to `FileInfo.RepositoryName`
* Remove TAP to logfile (unused)

PR-URL: #25771
Fixes: #25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: bump cpplint.py to 3d8f6f876d refack/node
3 participants
@refack @thefourtheye @cclauss